Fix truncated battles on attempted thread stop#85
Merged
Conversation
Member
|
@jkflying Thank you for the fix. ❤️ |
flemming-n-larsen
added a commit
that referenced
this pull request
May 18, 2026
Documents the NPE fix that caused battles to be truncated when a robot thread stop was attempted, with credits to Julian Kent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
flemming-n-larsen
added a commit
that referenced
this pull request
May 18, 2026
This reverts commit f45493a.
flemming-n-larsen
added a commit
that referenced
this pull request
May 18, 2026
Documents the NPE fix that caused battles to be truncated when a robot thread stop was attempted, with credits to Julian Kent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
flemming-n-larsen
added a commit
that referenced
this pull request
May 18, 2026
Documents the NPE fix that caused battles to be truncated when a robot thread stop was attempted, with credits to Julian Kent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
@jkflying I released 1.10.3. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue with the new security manager. If the thread stop fails there is a NPE which ends up aborting the battle early. This causes battles to be reported with their results, but the wrong number of rounds.
The fix is to take a reference to the thread beforehand so that we don't throw the NPE when the forceStop() sets it to null.